-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove v1alpha3 version #1396
Remove v1alpha3 version #1396
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I solved above problem by modifying "typeMappings": {
"V1Time": "datetime",
"V1UnstructuredUnstructured": "dict()"
} I checked our Notebook example and it is working. |
7da558e
to
68ba3e6
Compare
After some tests, I think it's better to use In that case, we can use As well, it is useful in KFP Katib launcher. We can use default mechanism of serialisation de-serialisation instead of writing our own function, like I did here: https://github.com/kubeflow/pipelines/blob/7f101c5e41f1e9cef02e6a94225e97815fc2327f/components/kubeflow/katib-launcher/src/launch_experiment.py#L63-L193. |
/lgtm |
Blocked by: #1392.
I removed v1alpha3 version since we use the v1beta1 in Kubeflow manifests.
As well, I removed unused Go packages from
Gopkg.toml
.For some reason,
v1_time.py
andv1_unstructured_unstructured.py
is not generated for the v1beta1 SDK. @jinchihe I saw your comment here: #1252 (comment).Do you know how we can include them to the SDK ?
Can we use Swagger Import Mappings for it ?
/assign @gaocegege @johnugeorge