Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing form fields to new UI #1463

Merged
merged 8 commits into from
Mar 12, 2021
Merged

Add missing form fields to new UI #1463

merged 8 commits into from
Mar 12, 2021

Commits on Mar 12, 2021

  1. ui(form): Add Trial Parameters 

    The form will be showing a dynamic list of trial parameters that the
users will need to configure. This list is affected from the yaml
content.

The JS parses the yaml contents to find the trial parameters.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
    @kimwnasptd
    kimwnasptd committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    3aed10f View commit details
    Browse the repository at this point in the history

  2. ui(form): Refactor the algorithm component 

    Create a common component for the algorithm settings. We will need this
for Early Stopping, which also has algorithm settings.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
    @kimwnasptd
    kimwnasptd committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    b1ae8b4 View commit details
    Browse the repository at this point in the history

  3. ui(form): Add support for early stopping 

    Add a distinct section for Early Stopping, when the Search Algorithm is
for Hyper Parameter tuning.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
    @kimwnasptd
    kimwnasptd committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    f02703d View commit details
    Browse the repository at this point in the history

  4. ui(form): Add resume policy to form 

    Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
    @kimwnasptd
    kimwnasptd committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    15ab94f View commit details
    Browse the repository at this point in the history

  5. ui(form): Small fixes to algo's settings 

    * The algorithm settings got applied in the form only after the user
  selected a different algorithm. The preselected value would not have
  the list of settings assigned once the form loads.
* Use null everywhere for the `random_state` parameter

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
    @kimwnasptd
    kimwnasptd committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    f4b7e51 View commit details
    Browse the repository at this point in the history

  6. review: Use correct form group 

    Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
    @kimwnasptd @andreyvelich
    kimwnasptd and andreyvelich committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    ba2d777 View commit details
    Browse the repository at this point in the history

  7. review: Use LongRunning for resumepolicy default 

    Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
    @kimwnasptd
    kimwnasptd committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    12e2dee View commit details
    Browse the repository at this point in the history

  8. ui(form): Use FormArray variable directly 

    Using "formGroup.get('trialParameters').controls" in the html results in
an error, during the build process. This is because Angular can't deduce that
the control returned from the get() method is a form array.

We will define a FormArray variable and use it directly instead of
get()ing it from he form group.

Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
    @kimwnasptd
    kimwnasptd committed Mar 12, 2021
    Configuration menu
    Copy the full SHA
    560a767 View commit details
    Browse the repository at this point in the history