-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release process script #1473
Add release process script #1473
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold for the review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
After discussion with @yanniszark, we decided to leave only one tag in Push and Build scripts and run them for the |
Thanks @andreyvelich! |
/lgtm |
New changes are detected. LGTM label has been removed. |
Thanks for the review! |
/retest |
Fixes: #1466.
I added Katib release script.
In
Makefile
we currently have:push-latest
to publish images to the registry with the latest and commit tags from the master branch.push-tag
to publish image to the registry with the release and commit tags from the release branch.release
to make a new Katib release.I changed
build.sh
andpush.sh
scripts to use them when publishinglatest
images andrelease
images.Release script follows this (e.g. Branch =
release-0.11
, Tag =v0.11.0
):release-0.11
), if it doesn't exist or use the existing branch.v0.11.0
in the Katib installs.0.11.0
.release-0.11
branch and addv0.11.0
tag to this commit.v1beta1-<commit-SHA>
andv0.11.0
.release-0.11
branch andv0.11.0
tag to the upstream.Please take a look.
/assign @yanniszark @gaocegege @johnugeorge