-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kustomization overlay: katib-openshift #1513
Add kustomization overlay: katib-openshift #1513
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Hi @maanur. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@googlebot I signed it! |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this effort, this is very helpful!
I think we should wait until we merge this PR: #1498, since we are making some changes to store Katib manifests.
After that, we can rebase this PR and merge it.
manifests/v1beta1/installs/katib-standalone-openshift/kustomization.yml
Outdated
Show resolved
Hide resolved
manifests/v1beta1/installs/katib-standalone-openshift/kustomization.yml
Outdated
Show resolved
Hide resolved
@andreyvelich I'll work on my PR tomorrow, hopefully it will then be ready to merge. If after that any help is needed with this PR I'm happy to provide assistance. |
Thank you for your help @davidspek! |
@maanur I apologies for the delays on this PR. |
/ok-to-test |
/test kubeflow-katib-presubmit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some comment to help migrate this PR to implement the changes introduced in #1498. After these changes this PR should be good to go.
manifests/v1beta1/installs/katib-openshift/katib-config-patch.yaml
Outdated
Show resolved
Hide resolved
81a6f90
to
7d71691
Compare
7d71691
to
83678f1
Compare
Manually tested against OpenShift version 4.6.21 |
@maanur Looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this effort @maanur!
I left few comments from my side.
It would be great if you could also left your review @yanniszark @nakfour @gaocegege @johnugeorge
manifests/v1beta1/installs/katib-openshift/patch-pvc-unset-storageClass.yaml
Outdated
Show resolved
Hide resolved
Thank you for the changes @maanur. |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can merge it.
Thank you for this effort @maanur!
/hold cancel
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, maanur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Current version of Katib have some issues and inconveniences when deployed to OpenShift, so I tried to introduce a workaround in form of kustomization overlay.
Workaround to #1512, but only for OpenShift 4.4+
Special notes for your reviewer:
Tested against OpenShift 4.6.21
Release note: