Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the Goptuna version up to v0.8.0 with IPOP-CMA-ES and BIPOP-CMA-ES support. #1519

Merged
merged 2 commits into from
Apr 23, 2021

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Apr 22, 2021

What this PR does / why we need it:
Upgrade goptuna version to v0.8.0 with following changes:

  • Add Katib options to enable IPOP-CMA-ES and BIPOP-CMA-ES.
  • Remove the use of deprecated APIs (Some study options are renamed without breaking changes).

ScreenShot 2021-04-22 19 17 55

https://github.com/c-bata/katib-goptuna-example/blob/master/experiment.yaml

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1283

Special notes for your reviewer:

  1. I added changes in the new UI (pkg/new-ui/v1beta1/frontend/src/app/constants/algorithms-settings.const.ts) but not checked whether it works.
  2. Goptuna supports Sobol's Quasi-random Sequence. I have a plan to add Sobol support in the following pull request.

Release note:

Support IPOP-CMA-ES and BIPOP-CMA-ES, restarting strategies for CMA-ES algorithm.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @c-bata, this is very helpful!
/cc @kimwnasptd for the UI review.

@@ -12,6 +12,9 @@ spec:
- Train-accuracy
algorithm:
algorithmName: cmaes
algorithmSettings:
- name: "restart_strategy"
value: "ipop"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also update the Kubeflow docs with the restart_strategy: https://www.kubeflow.org/docs/components/katib/experiment/#covariance-matrix-adaptation-evolution-strategy-cma-es.

Copy link
Member Author

@c-bata c-bata Apr 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've just opened a draft pull request at kubeflow/website#2642 👍

@andreyvelich
Copy link
Member

/cc @gaocegege @johnugeorge

@andreyvelich
Copy link
Member

/retest

@kimwnasptd
Copy link
Member

/lgtm

Thanks for also updating the docs 😄

Comment on lines +92 to +97
{
name: 'restart_strategy',
value: 'none',
values: ['none', 'ipop', 'bipop'],
type: AlgorithmSettingType.STRING,
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the new Katib UI.

ScreenShot 2021-04-23 21 15 12

@andreyvelich
Copy link
Member

Looks great, thanks @c-bata!
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, c-bata

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit c36ac54 into kubeflow:master Apr 23, 2021
@c-bata c-bata deleted the goptuna-0-8-0 branch April 23, 2021 14:03
@yanniszark yanniszark mentioned this pull request May 17, 2021
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Goptuna to v0.8.0 which supports IPOP-CMA-ES and BIPOP-CMA-ES.
4 participants