-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the Goptuna version up to v0.8.0 with IPOP-CMA-ES and BIPOP-CMA-ES support. #1519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @c-bata, this is very helpful!
/cc @kimwnasptd for the UI review.
@@ -12,6 +12,9 @@ spec: | |||
- Train-accuracy | |||
algorithm: | |||
algorithmName: cmaes | |||
algorithmSettings: | |||
- name: "restart_strategy" | |||
value: "ipop" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also update the Kubeflow docs with the restart_strategy
: https://www.kubeflow.org/docs/components/katib/experiment/#covariance-matrix-adaptation-evolution-strategy-cma-es.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I've just opened a draft pull request at kubeflow/website#2642 👍
/retest |
/lgtm Thanks for also updating the docs 😄 |
{ | ||
name: 'restart_strategy', | ||
value: 'none', | ||
values: ['none', 'ipop', 'bipop'], | ||
type: AlgorithmSettingType.STRING, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @c-bata! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, c-bata The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Upgrade goptuna version to v0.8.0 with following changes:
https://github.com/c-bata/katib-goptuna-example/blob/master/experiment.yaml
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1283
Special notes for your reviewer:
I added changes in the new UI (pkg/new-ui/v1beta1/frontend/src/app/constants/algorithms-settings.const.ts
) but not checked whether it works.Release note: