Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty resources for CPU and Memory in Katib config #1564

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Allow empty resources for CPU and Memory in Katib config #1564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions pkg/util/v1beta1/katibconfig/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,18 @@ func setResourceRequirements(configResource corev1.ResourceRequirements) corev1.
configResource.Limits[corev1.ResourceEphemeralStorage] = defaultDiskLimit
}

// If user explicitly sets CPU value to -1, nuke it.
if cpuLimit.Sign() == -1 && cpuRequest.Sign() == -1 {
delete(configResource.Limits, corev1.ResourceCPU)
delete(configResource.Requests, corev1.ResourceCPU)
}

// If user explicitly sets Memory value to -1, nuke it.
if memLimit.Sign() == -1 && memRequest.Sign() == -1 {
delete(configResource.Limits, corev1.ResourceMemory)
delete(configResource.Requests, corev1.ResourceMemory)
}

// If user explicitly sets ephemeral-storage value to something negative, nuke it.
// This enables compability with the GKE nodepool autoscalers, which cannot scale
// pods which define ephemeral-storage resource constraints.
Expand Down