Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install charmcraft 1.0.0 #1593

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

DomFleischmann
Copy link
Contributor

@DomFleischmann DomFleischmann commented Jul 28, 2021

Install charmcraft 1.0.0 through pip for now until we move to pytest-operator tests.

Install charmcraft 1.0.0 through pip for now
until we move to pytest-operator tests.
@DomFleischmann DomFleischmann changed the title Juju Bundle build with LXD user group Install charmcraft 1.0.0 Jul 28, 2021
@DomFleischmann DomFleischmann marked this pull request as ready for review July 28, 2021 14:18
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this @DomFleischmann!
/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, DomFleischmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit f1d565e into kubeflow:master Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants