Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the minimal kustomize version in the developer guide #1675

Merged

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Sep 23, 2021

What this PR does / why we need it:

We will change the minimal kubectl version in #1667. So, we should change the minimal kustomize version in the developer guide.

Ref:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@aws-kf-ci-bot
Copy link
Contributor

Hi @tenzen-y. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tenzen-y tenzen-y changed the title Change kustomize version in the developer guide Change the minimul kustomize version in the developer guide Sep 23, 2021
@tenzen-y tenzen-y changed the title Change the minimul kustomize version in the developer guide Change the minimal kustomize version in the developer guide Sep 23, 2021
@tenzen-y
Copy link
Member Author

/assign

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update!
/ok-to-test
/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit b0e9174 into kubeflow:master Sep 23, 2021
@tenzen-y tenzen-y deleted the change-require-kustomize-version branch September 23, 2021 18:11
@anencore94
Copy link
Member

From kubeflow/manifests repository's README, The required version of kustomize was v3.x, not v4.x.
And I guess the problem was not resolved yet following by this issue
Is it ok to upgrade the kustomize version in Katib though? @tenzen-y @andreyvelich

@tenzen-y
Copy link
Member Author

Thank you for your comment! @anencore94

Previously, Katib could not be installed with kustomize v4.x. However, the problem has been resolved in #1498 and kubeflow/manifests#1840. So I believe there is no problem.

@anencore94
Copy link
Member

Oh I see, Thank you for check :) @tenzen-y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants