Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhance] change default metrics collect format #1707

Conversation

anencore94
Copy link
Member

@anencore94 anencore94 commented Oct 8, 2021

What this PR does / why we need it:

  • to parse scientific notation well

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1702

Checklist:

  • Docs included if any changes are user facing

-  to parse scientific notation well
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this update @anencore94!
Small comment from me.

pkg/metricscollector/v1beta1/common/const.go Show resolved Hide resolved
@andreyvelich
Copy link
Member

andreyvelich commented Oct 9, 2021

Also, please submit the PR to update documentation: https://www.kubeflow.org/docs/components/katib/experiment/#metrics-collector.
We add the default metrics format there.

Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
@anencore94
Copy link
Member Author

Also, please submit the PR to update documentation: https://www.kubeflow.org/docs/components/katib/experiment/#metrics-collector.
We add the default metrics format there.

Ok, Thanks for notifying :)

@johnugeorge
Copy link
Member

/lgtm

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @anencore94!
/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, anencore94

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 487b012 into kubeflow:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics in scientific notation are not correctly parsed by default
4 participants