-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance/UI feasible space #1721
Enhance/UI feasible space #1721
Conversation
Hi @seong7. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: seong7 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @kimwnasptd |
/ok-to-test |
Can we know the progress of this PR? 😄 |
Sorry for the long waiting time @seong7. @kimwnasptd Please can you check this PR also ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one small comment @seong7, thanks for the work!
pkg/new-ui/v1beta1/frontend/src/app/shared/params-list/add-modal/add-modal.component.scss
Outdated
Show resolved
Hide resolved
Thanks for helping improving the web app @seong7! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd, seong7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
In parameter modal ui,
Min
,Max
andStep
inputs asnumber
, sincestring
type of input must not be passed.Step
input from being0
or0.0000...
, since the step0
does not make sense in the min-max range.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: