Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance/UI feasible space #1721

Merged
merged 3 commits into from
Dec 1, 2021

Conversation

seong7
Copy link
Contributor

@seong7 seong7 commented Oct 25, 2021

What this PR does / why we need it:

In parameter modal ui,

  • this PR restricts the type of Min, Max and Step inputs as number, since string type of input must not be passed.
  • this PR prevents the Step input from being 0 or 0.0000..., since the step 0 does not make sense in the min-max range.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@aws-kf-ci-bot
Copy link
Contributor

Hi @seong7. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: seong7
To complete the pull request process, please assign kimwnasptd after the PR has been reviewed.
You can assign the PR to them by writing /assign @kimwnasptd in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnugeorge
Copy link
Member

/assign @kimwnasptd

@andreyvelich
Copy link
Member

/ok-to-test

@seong7
Copy link
Contributor Author

seong7 commented Nov 24, 2021

Can we know the progress of this PR? 😄

@andreyvelich
Copy link
Member

Sorry for the long waiting time @seong7.

@kimwnasptd Please can you check this PR also ?

Copy link
Member

@kimwnasptd kimwnasptd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small comment @seong7, thanks for the work!

@kimwnasptd
Copy link
Member

Thanks for helping improving the web app @seong7!

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Dec 1, 2021
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kimwnasptd, seong7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a701fd6 into kubeflow:master Dec 1, 2021
@seong7 seong7 deleted the enhance/ui-feasiblespace branch December 21, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants