Fix clusterrole of katib-controller to access image pull secrets

[henrysecond1]

What this PR does / why we need it:

To pull remote image using imagePullSecrets,
katib-controller should be able to access the secrets in other namespaces.

• https://github.com/kubeflow/katib/blob/master/pkg/webhook/v1beta1/pod/utils.go#L62-L66

We experienced the below error when we tried to pull images with imagePullSecrets.

Error creating: admission webhook "mutator.pod.katib.kubeflow.org" denied the request: Failed to create k8schain: secrets "secret" is forbidden: User "system:serviceaccount:kubeflow:katib-controller" cannot get resource "secrets" in API group "" in the namespace "test"

The above error disappeared after adding secrets resource to ClusterRole.

Please take a look, thanks

[aws-kf-ci-bot]

Hi @henrysecond1. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[andreyvelich]

Thank you for fixing this @henrysecond1!
/lgtm
/assign @gaocegege @johnugeorge

[coveralls]

Coverage remained the same at 73.696% when pulling fc0c2d4 on henrysecond1:fix/katib-controller-rbac into b176b04 on kubeflow:master.

[henrysecond1]

/retest

[aws-kf-ci-bot]

@henrysecond1: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[gaocegege]

/ok-to-test

[gaocegege]

/retest

[andreyvelich]

/approve

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, henrysecond1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andreyvelich]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment