Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the default Metrics Collector regex #1755

Conversation

andreyvelich
Copy link
Member

Fixes: #1754.
I fixed the default regex format.
I will create separate PR to update the website doc.

/assign @kubeflow/wg-automl-leads
/cc @RDarrylR @anencore94

@google-oss-prow
Copy link

@andreyvelich: GitHub didn't allow me to request PR reviews from the following users: RDarrylR.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Fixes: #1754.
I fixed the default regex format.
I will create separate PR to update the website doc.

/assign @kubeflow/wg-automl-leads
/cc @RDarrylR @anencore94

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 74.138% when pulling 3e72661 on andreyvelich:issue-1754-fix-metrics-collector-regex into bb439fa on kubeflow:master.

@anencore94
Copy link
Member

That's my bad. Thanks so much for the fix
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 1, 2021
@google-oss-prow google-oss-prow bot merged commit 326089d into kubeflow:master Dec 1, 2021
@andreyvelich andreyvelich deleted the issue-1754-fix-metrics-collector-regex branch December 2, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent metrics filter change broke metrics collection for non-scientific values
3 participants