Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prometheus scraping and grafana support to charmed katib-controller operator #1839

Merged
merged 14 commits into from
Apr 14, 2022

Conversation

jardon
Copy link
Contributor

@jardon jardon commented Mar 28, 2022

What this PR does / why we need it:
These changes add support for prometheus scraping and providing a grafana dashboard to the charmed katib-controller operator. With the changes you can do the following to connect the applications and enable scraping:

juju relate prometheus-k8s katib-controller
juju relate grafana-k8s katib-controller

Checklist:

  • Docs included if any changes are user facing

@aws-kf-ci-bot
Copy link
Contributor

Hi @jardon. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented Mar 29, 2022

Coverage Status

Coverage decreased (-0.4%) to 73.706% when pulling f27be59 on jardon:monitoring into 9c88bbc on kubeflow:master.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

ca-scribner and others added 5 commits April 11, 2022 13:49
These are not working properly.  When connecting to grafana, the dashboard shows up but does not populate properly with data.  The data source appears wrong
Without this, upgrade-charm does not work.
Update grafana/prometheus implementation for charmed operator of katib
@ca-scribner
Copy link
Contributor

/retest

@ca-scribner
Copy link
Contributor

I think this just failed because the github runner was particularly slow. Not sure how to get the tests to rerun though

@gaocegege
Copy link
Member

I rerun the jobs manually.

@ca-scribner
Copy link
Contributor

ty! We bumped the timeout on the flaky test too so it shouldn't fail like it did before. This should be good to go now

@johnugeorge
Copy link
Member

@ca-scribner Can you lgtm this PR if it is ready to be merged?

@ca-scribner
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 13, 2022
@johnugeorge
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ca-scribner, jardon, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e031b5e into kubeflow:master Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants