Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the Tensorflow version to address some security issues #1870

Merged
merged 4 commits into from
Jun 3, 2022
Merged

Upgrade the Tensorflow version to address some security issues #1870

merged 4 commits into from
Jun 3, 2022

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented May 23, 2022 •
edited
Loading

What this PR does / why we need it:
I upgraded the TensorFlow version to address some security issues.
Also, I modified the sample code for ENAS to work in Tensorflow 2.9.1 env.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@tenzen-y tenzen-y changed the title Upgrade the Tensorflow version to address some security issues [WIP] Upgrade the Tensorflow version to address some security issues May 23, 2022
@tenzen-y tenzen-y force-pushed the upgrade-tensorflow-version branch 2 times, most recently from 3f3e0d3 to bc865fe Compare May 23, 2022 14:42
@google-oss-prow google-oss-prow bot added size/M and removed size/S labels May 23, 2022
@tenzen-y tenzen-y changed the title [WIP] Upgrade the Tensorflow version to address some security issues Upgrade the Tensorflow version to address some security issues May 23, 2022
@coveralls
Copy link

coveralls commented May 23, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 73.829% when pulling 7ade8bd on tenzen-y:upgrade-tensorflow-version into a9d92bd on kubeflow:master.

@tenzen-y tenzen-y force-pushed the upgrade-tensorflow-version branch from cdab893 to 747cc7f Compare May 23, 2022 19:27
@tenzen-y
Copy link
Member Author

/retest

@tenzen-y
Copy link
Member Author

I have upgraded tensorflow-aarch64 to v2.9.0.

@google-oss-prow google-oss-prow bot mentioned this pull request May 25, 2022
Closed
anencore94
anencore94 reviewed May 25, 2022
View reviewed changes
Copy link
Member

@anencore94 anencore94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cmd/suggestion/nas/enas/v1beta1/requirements.txt Outdated
Comment on lines 4 to 9
tensorflow==2.8.0
tensorflow==2.9.1; platform_machine=="x86_64"
tensorflow-aarch64==2.9.0; platform_machine=="aarch64"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks better condition at requirements.txt 👍

nit question: don't we have to match the hotfix version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your comment.
The tensorflow-aarch64 v2.9.1 has not yet been released.
Ref: https://pypi.org/project/tensorflow-aarch64/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then does it better to set both to v2.9.0 until aarch64 support v2.9.1?

Copy link
Member Author

@tenzen-y tenzen-y May 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the Tensorflow v2.9.0 has installation issues. So it would be best to wait for upgrading until the released tensorflow-aarch64 v2.9.1. Thanks for your suggestion @anencore94 !

Ref:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I didn't know that! Thanks for the clarifying :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided to merge this PR without waiting for tensorflow-aarch64 v2.9.1 as discussed in #1882 (comment)

@google-oss-prow google-oss-prow bot added the lgtm label May 25, 2022
@tenzen-y
Copy link
Member Author

/hold

@johnugeorge
Copy link
Member

Thanks @tenzen-y

/approve

Please remove hold when done

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member Author

Thanks @tenzen-y

/approve

Please remove hold when done

I will update PR after tensorflow-aarch64 v2.9.1 has been released as discussed in this.

@johnugeorge johnugeorge mentioned this pull request Jun 3, 2022
Merged
1 task
@google-oss-prow google-oss-prow bot removed the lgtm label Jun 3, 2022
@tenzen-y tenzen-y force-pushed the upgrade-tensorflow-version branch from 954ec5d to 7ade8bd Compare June 3, 2022 19:24
@tenzen-y
Copy link
Member Author

tenzen-y commented Jun 3, 2022

/unhold
@johnugeorge Please take a look.

@tenzen-y
Copy link
Member Author

tenzen-y commented Jun 3, 2022

/assign @johnugeorge

@johnugeorge
Copy link
Member

Thanks!
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 3, 2022
@google-oss-prow google-oss-prow bot merged commit 90c3481 into kubeflow:master Jun 3, 2022
@tenzen-y tenzen-y deleted the upgrade-tensorflow-version branch June 3, 2022 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anencore94 anencore94 anencore94 left review comments

@sperlingxx sperlingxx Awaiting requested review from sperlingxx

Assignees

@johnugeorge johnugeorge

@anencore94 anencore94

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tenzen-y @coveralls @johnugeorge @anencore94