Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for arm64 in pytorch-mnist image #1943

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
I modified Dockerfile for pytorch-mnist to support arm64.
Also, I have tested using the following commands:

$ # For linux/arm64 with cuda
$ docker run -it --pull always --platform linux/arm64 ytenzen/multiplatform-pytorch-gpu:latest --epochs=1 --batch-size=256
$ # For linux/amd64 with cuda
$ docker run -it --pull always --platform linux/amd64 ytenzen/multiplatform-pytorch-gpu:latest --epochs=1 --batch-size=256
$ # For linux/arm64
$ docker run -it --pull always --platform linux/arm64 ytenzen/multiplatform-pytorch-cpu:latest --epochs=1 --batch-size=256
$ # For linux/amd64
$ docker run -it --pull always --platform linux/amd64 ytenzen/multiplatform-pytorch-cpu:latest --epochs=1 --batch-size=256

/hold until #1940 is merged

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part-of #1900

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Aug 29, 2022

Coverage Status

Coverage increased (+0.1%) to 73.545% when pulling fced2a3 on tenzen-y:support-for-arm64-in-pytorch-mnist-image into 3906f8e on kubeflow:master.

@tenzen-y tenzen-y force-pushed the support-for-arm64-in-pytorch-mnist-image branch from b4e1c70 to 7055eb4 Compare August 29, 2022 20:27
@tenzen-y tenzen-y force-pushed the support-for-arm64-in-pytorch-mnist-image branch from 7055eb4 to fced2a3 Compare August 29, 2022 20:53
@tenzen-y
Copy link
Member Author

/hold cancel

@tenzen-y
Copy link
Member Author

This PR is ready to merge.

/assign @johnugeorge @gaocegege @andreyvelich

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Aug 30, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 6870587 into kubeflow:master Aug 30, 2022
@tenzen-y tenzen-y deleted the support-for-arm64-in-pytorch-mnist-image branch August 30, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants