Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for arm64 in simple-pbt image #1948

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Sep 4, 2022

Signed-off-by: tenzen-y yuki.iwai.tz@gmail.com

What this PR does / why we need it:
I modified the Dockerfile for simple-pbt to support arm64 and I have tested on my local using the below commands:

  • linux/arm64
docker run -it --platform linux/arm64 ytenzen/multiplatform-simple-pbt:latest --epochs=10
  • linux/amd64
docker run -it --platform linux/amd64 ytenzen/multiplatform-simple-pbt:latest --epochs=10

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part-of #1900

Checklist:

  • Docs included if any changes are user facing

@tenzen-y tenzen-y changed the title Support for arm64 in simple-pbt images Support for arm64 in simple-pbt image Sep 4, 2022
Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the support-for-arm64-in-simple-pbt-image branch from b556218 to 405399a Compare September 4, 2022 08:01
@coveralls
Copy link

coveralls commented Sep 4, 2022

Coverage Status

Coverage increased (+0.1%) to 73.545% when pulling 405399a on tenzen-y:support-for-arm64-in-simple-pbt-image into 58a3f4b on kubeflow:master.

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 077cf4d into kubeflow:master Sep 4, 2022
@tenzen-y tenzen-y deleted the support-for-arm64-in-simple-pbt-image branch September 4, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants