Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the katib-new-ui for Charmed gh-actions #1987

Merged

Conversation

tenzen-y
Copy link
Member

Signed-off-by: tenzen-y yuki.iwai.tz@gmail.com

What this PR does / why we need it:
As discussed in this, I changed the UI component to katib-new-ui for Charmed GH-Action.

/assign @andreyvelich @DomFleischmann @knkski @ca-scribner

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
@coveralls
Copy link

coveralls commented Oct 28, 2022

Coverage Status

Coverage remained the same at 73.545% when pulling 4b314a0 on tenzen-y:use-katib-new-ui-in-charmed-test into aee2109 on kubeflow:master.

@DomFleischmann
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 1, 2022
@DomFleischmann
Copy link
Contributor

/approve

1 similar comment
@johnugeorge
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DomFleischmann, johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 6b55540 into kubeflow:master Nov 1, 2022
@tenzen-y tenzen-y deleted the use-katib-new-ui-in-charmed-test branch November 2, 2022 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants