Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Migrate from tslint to eslint in KWA #2042

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

elenzio9
Copy link
Contributor

In this PR:

  • Remove TSLint since it's deprecated
  • Introduce ESLint
  • Fix linting errors
  • Introduce a Github action to run a lint check

Remove TSLint since it's deprecated.

Signed-off-by: Elena Zioga <elena@arrikto.com>
Introduce ESLint by using the following Angular command [1]:

ng add @angular-eslint/schematics

[1] https://github.com/angular-eslint/angular-eslint#quick-start-with-angular-v12-and-later

Signed-off-by: Elena Zioga <elena@arrikto.com>
Fix linting errors.

Signed-off-by: Elena Zioga <elena@arrikto.com>
Introduce a Github action to run a lint check.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@kimwnasptd
Copy link
Member

The action now gets triggered and the frontend changes look good.

The failing GH Actions seem to be a fluke, so we'll wait for the repo admins to re-run them. From my end

/lgtm
/approve

@andreyvelich
Copy link
Member

Thank you for this @elenzio9!
I restarted the failed actions.

@andreyvelich
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, elenzio9, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 0d0e77f into kubeflow:master Dec 1, 2022
@kimwnasptd kimwnasptd deleted the feature-elena-kwa-eslint branch December 1, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants