Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Changelog for Katib v0.15.0-rc.0 #2106

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Add Changelog for Katib v0.15.0-rc.0 #2106

merged 3 commits into from
Feb 23, 2023

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Jan 27, 2023 •
edited
Loading

I added Katib Changelog for Katib v0.15.0-rc.0

I grouped PRs in the following categories:

  • Core Features
  • UI Improvements
  • SDK Improvements
  • Bug fixes
  • Documentation
  • Misc

Please check the PR grouping and let me know what we should change.

I think, when we are going to make official Katib 0.15 release and create a GitHub release, we should point all breaking changes and the most valuable features to the Top.

It is one of the biggest Katib releases (over 130 commits) with a lot of great new features.
Thanks everyone for your hard work!

/assign @johnugeorge @gaocegege @tenzen-y @anencore94 @kimwnasptd @elenzio9 @orfeas-k @apo-ger @d-gol @shaowei-su @zhixian82 @fischor @keisuke-umezawa

@google-oss-prow
Copy link

@andreyvelich: GitHub didn't allow me to assign the following users: keisuke-umezawa, shaowei-su, zhixian82, fischor, d-gol.

Note that only kubeflow members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

I added Katib Changelog for Katib v0.15.0-rc.0

I grouped PRs in the following categories:

  • Core Features
  • UI Improvements
  • SDK Improvements
  • Bug fixes
  • Documentation
  • Misc

Please check the PR grouping and let me know what we should change.

I think, when we are going to make official Katib 0.15 release and create a GitHub release, we should point all breaking changes and the most valuable features to the Top.

It is one of the biggest Katib releases (over 130 commits) with a lot of great new features.
Thanks everyone for your hard work!

/assign @johnugeorge @gaocegege @tenzen-y @anencore94 @kimwnasptd @elenzio9 @orfeas-k @apo-ger @d-gol @shaowei-su @zhixian82 @fischor @keisuke-umezawa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

anencore94
anencore94 reviewed Jan 28, 2023
View reviewed changes
Copy link
Member

@anencore94 anencore94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for all of your efforts 👍

CHANGELOG.md
- frontend: Enable actions in experiment graph ([#2065](https://github.com/kubeflow/katib/pull/2065) by [@elenzio9](https://github.com/elenzio9))
- frontend: Show message in case of uncompleted trial instead of the graph ([#2063](https://github.com/kubeflow/katib/pull/2063) by [@elenzio9](https://github.com/elenzio9))
- frontend: Add source maps in the browser ([#2043](https://github.com/kubeflow/katib/pull/2043) by [@elenzio9](https://github.com/elenzio9))
- Backend for getting logs of a trial ([#2039](https://github.com/kubeflow/katib/pull/2039) by [@d-gol](https://github.com/d-gol))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where this feature belongs to : UI improvement or Core Features

Copy link
Member Author

@andreyvelich andreyvelich Jan 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anencore94 These backend changes were necessary to show Trial logs in the Katib UI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying :)

CHANGELOG.md
Comment on lines +77 to +86
- Update CHANGELOG for v0.14.0 release ([#1932](https://github.com/kubeflow/katib/pull/1932) by [@johnugeorge](https://github.com/johnugeorge))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this PR #2106 should include itself ? 🤣

Copy link
Member Author

@andreyvelich andreyvelich Jan 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anencore94 The Changelog generator script looks for changes between release branches (release-0.14 and release-0.15).
Since we don't include this PR in the release branch, we don't have it there.
We can consider cherry-picking this PR one the release branch. Then, we are going to see it in the following RCs.

@google-oss-prow google-oss-prow bot added the lgtm label Jan 28, 2023
tenzen-y
tenzen-y reviewed Jan 28, 2023
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating this!

we should point all breaking changes and the most valuable features to the Top.

Do you think which features are breaking changes?

CHANGELOG.md Outdated
- Upgrade Tensorflow version ([#2079](https://github.com/kubeflow/katib/pull/2079) by [@tenzen-y](https://github.com/tenzen-y))
- Upgrade Python version to 3.10 ([#2057](https://github.com/kubeflow/katib/pull/2057) by [@tenzen-y](https://github.com/tenzen-y))
- Remove Chocolate Suggestion Service ([#2071](https://github.com/kubeflow/katib/pull/2071) by [@tenzen-y](https://github.com/tenzen-y))
- Support for grid search algorithm in Optuna Suggestion Service ([#2060](https://github.com/kubeflow/katib/pull/2060) by [@tenzen-y](https://github.com/tenzen-y))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be the core feature since we support a new algorithm for Optuna.
WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, let me move it to the Core.

@andreyvelich
Copy link
Member Author

andreyvelich commented Jan 30, 2023 •
edited
Loading

Do you think which features are breaking changes?

I think, we should discuss about it during our next WG meeting. Let me add this item to the agenda doc.

@google-oss-prow google-oss-prow bot removed the lgtm label Jan 30, 2023
@tenzen-y
Copy link
Member

Do you think which features are breaking changes?

I think, we should discuss about it during our next WG meeting. Let me add this item to the agenda doc.

Sounds good.

@tenzen-y
Copy link
Member

Do you think which features are breaking changes?

I think, we should discuss about it during our next WG meeting. Let me add this item to the agenda doc.

Sounds good.

I added a comment about candidates for breaking changes.

@andreyvelich
Copy link
Member Author

andreyvelich commented Feb 9, 2023 •
edited
Loading

@gaocegege @johnugeorge @tenzen-y @anencore94 @kimwnasptd @elenzio9 @jbottum I've added Breaking Changes and Major Changes to our CHANGELOG based on our last discussion during WG meeting.
Please let me know if that sounds good.

@tenzen-y
Copy link
Member

tenzen-y commented Feb 9, 2023

SGTM

@andreyvelich
Copy link
Member Author

As we discussed on the recent WG meeting, we can merge this Changelog.
Thanks everyone again for your work and review!

@andreyvelich
Copy link
Member Author

/hold cancel

@andreyvelich andreyvelich changed the title [WIP] Add Changelog for Katib v0.15.0-rc.0 Add Changelog for Katib v0.15.0-rc.0 Feb 23, 2023
@andreyvelich
Copy link
Member Author

The tests have been passed, @tenzen-y @johnugeorge @anencore94 please give your /lgtm if are ok with the changes.

@tenzen-y
Copy link
Member

Thank you!
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 23, 2023
@google-oss-prow google-oss-prow bot merged commit cff0002 into kubeflow:master Feb 23, 2023
@andreyvelich andreyvelich deleted the add-changelog-v0.15.0-rc.0 branch February 23, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@anencore94 anencore94 anencore94 left review comments

@johnugeorge johnugeorge Awaiting requested review from johnugeorge

Assignees

@johnugeorge johnugeorge

@gaocegege gaocegege

@kimwnasptd kimwnasptd

@anencore94 anencore94

@orfeas-k orfeas-k

@tenzen-y tenzen-y

@elenzio9 elenzio9

@apo-ger apo-ger

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@andreyvelich @tenzen-y @anencore94 @johnugeorge @gaocegege @kimwnasptd @orfeas-k @elenzio9 @apo-ger