-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Raise more human-readable name conflict exception #2199
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
/assign @andreyvelich |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating this @droctothorpe
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, droctothorpe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@droctothorpe Please can you rebase your PR, it should fix the E2Es. |
Co-authored-by: andreafehrman <andrea.k.fehrman@vanderbilt.edu> Co-authored-by: harrisonfritz <harrisonmichaelfritz@gmail.com>
Squashed and rebased @andreyvelich. Thank you! |
Thank you! |
What this PR does / why we need it:
If you call
KatibClient.tune
using an experiment name that already exists, you get a giant traceback with the relevant / helpful message not being at the bottom. We had a user struggle to debug this on their own.This PR simply raises a more helpful exception in the event of a 409 (name conflict) response from the API.
Checklist: