Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Raise more human-readable name conflict exception #2199

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

droctothorpe
Copy link
Contributor

What this PR does / why we need it:
If you call KatibClient.tune using an experiment name that already exists, you get a giant traceback with the relevant / helpful message not being at the bottom. We had a user struggle to debug this on their own.

This PR simply raises a more helpful exception in the event of a 409 (name conflict) response from the API.

Checklist:

  • Docs included if any changes are user facing

@google-cla
Copy link

google-cla bot commented Aug 8, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@droctothorpe droctothorpe changed the title [SDK]: Raise more human-readable name conflict exception [SDK] Raise more human-readable name conflict exception Aug 8, 2023
@droctothorpe
Copy link
Contributor Author

/assign @andreyvelich

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this @droctothorpe
/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Sep 6, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, droctothorpe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member

@droctothorpe Please can you rebase your PR, it should fix the E2Es.

Co-authored-by: andreafehrman <andrea.k.fehrman@vanderbilt.edu>
Co-authored-by: harrisonfritz <harrisonmichaelfritz@gmail.com>
@droctothorpe
Copy link
Contributor Author

@droctothorpe Please can you rebase your PR, it should fix the E2Es.

Squashed and rebased @andreyvelich. Thank you!

@tenzen-y
Copy link
Member

tenzen-y commented Sep 7, 2023

Thank you!
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Sep 7, 2023
@google-oss-prow google-oss-prow bot merged commit 520a397 into kubeflow:master Sep 7, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants