-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start waiting for certs to be ready before sending data to the channel #2209
Start waiting for certs to be ready before sending data to the channel #2209
Conversation
185a325
to
2d03bc4
Compare
Start waiting for certs to be ready before sending data to the channel Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
2d03bc4
to
6892837
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeflow#2209) Start waiting for certs to be ready before sending data to the channel Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
…efore sending data to the channel (#2215) Start waiting for certs to be ready before sending data to the channel Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
What this PR does / why we need it:
Currently, the controller checks if the cert-generator is enabled before starting
setupControllers
.katib/cmd/katib-controller/v1beta1/main.go
Lines 136 to 149 in 7f0d922
So, if the cert-generator is disabled, the controller sends data to
certsReady
channel before the controller starts waiting for certs to get ready. By this behavior, in the katib-with-kubeflow, the controller eternally keeps waiting for the certs to get ready.katib/cmd/katib-controller/v1beta1/main.go
Lines 170 to 171 in 7f0d922
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: