-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Python version to 3.11 #2278
Upgrade Python version to 3.11 #2278
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold We need to upgrade other library versions first. |
@@ -45,7 +45,7 @@ runtime: | |||
image: docker.io/kubeflowkatib/suggestion-enas:latest | |||
resources: | |||
limits: | |||
memory: 200Mi | |||
memory: 400Mi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After I upgraded the Python version, I faced OOM killed in the ENAS suggestion service.
9e33a4b
to
1ab6dc5
Compare
93248d1
to
600fbb2
Compare
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
600fbb2
to
28a14f7
Compare
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
28a14f7
to
75821d6
Compare
Ready for the review. PTAL. /assign @andreyvelich @johnugeorge |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @tenzen-y!
A few questions:
- Do we want to add support for Python 3.11 in Katib SDK: https://github.com/kubeflow/katib/blob/master/sdk/python/v1beta1/setup.py#L61 ?
- Do we want to add this change before the next Katib release ?
@andreyvelich It's a good question.
|
How strict we want to be with our SDK versions since it is user facing interface and sometimes users might be on the out-of-date environments ? However, I prefer approach which Jupyter Lab and Jupyter Server follow where they add minimal Python version that is supported by today. Could you give your feedback on this @kubeflow/wg-training-leads @droctothorpe @shipengcheng1230 @andreafehrman @harrisonfritz |
I'm ok with either way, but I believe that we should define deprecation or support policies for SDK with Python version. So, should we keep supported Python versions in this PR, and then open a dedicated issue and discuss the Python version? @andreyvelich WDYt? |
That's fine I believe. Let's create dedicated issue to discuss long-term support for SDK Python versions. |
I created: #2283 |
@andreyvelich So, can we merge this? |
Yeah, let's merge it! |
* Upgrade Python version to 3.11 Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Upgrade the numpy version to 1.25.2 Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Increase resource requests for the ENAS suggestion service Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Update pytest CI Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> * Prepare dedicated pytest for skopt Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> --------- Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com> Signed-off-by: Muhammed Magdy <muhammedmagdy1015@gmail.com>
What this PR does / why we need it:
I upgraded the Python version to 3.11 since Python 3.10 no longer fixes bugs, according to this.
Also, I upgraded some libraries to switch Python 3.11 supported version:
Additionally, we keep the library and Python version for the skopt since some dependencies error occurs due to stopped maintenance: #2280.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: