Drop Kubernetes v1.25, and Support Kubernetes v1.28 #2303
Conversation
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
google-oss-prow
bot
requested review from
andreyvelich,
anencore94 and
gaocegege
| Metrics: metricsserver.Options{ | ||
| BindAddress: initConfig.ControllerConfig.MetricsAddr, | ||
| }, |
There was a problem hiding this comment.
I addressed this breaking: kubernetes-sigs/controller-runtime#2407
| @@ -38,6 +38,7 @@ echo ">> Using ${CODEGEN_PKG} for the code generator" | |||
|
|
|||
| # Ensure we can execute. | |||
| chmod +x "${CODEGEN_PKG}/generate-groups.sh" | |||
| chmod +x "${CODEGEN_PKG}/generate-internal-groups.sh" | |||
There was a problem hiding this comment.
I addressed this error:
/Users/tenzen/go/pkg/mod/k8s.io/code-generator@v0.28.8/generate-groups.sh: line 66: /Users/tenzen/go/pkg/mod/k8s.io/code-generator@v0.28.8/generate-internal-groups.sh: Permission denied
pkg/apis/apis.go:18: running "../../hack/update-codegen.sh": exit status 126
make: *** [generate] Error 1
|
/assign @andreyvelich @johnugeorge |
There was a problem hiding this comment.
Thank you for updating the Kubernetes version @tenzen-y!
I noticed that we should also update the website: https://www.kubeflow.org/docs/components/katib/hyperparameter/#prerequisites
Version is very out-of-date there.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Oh, I see. I will submit a PR to the website. |
What this PR does / why we need it:
I updated supporting Kubernetes versions.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part-of #2256
Checklist: