-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test fields private in Go unit tests #2316
Make test fields private in Go unit tests #2316
Conversation
Signed-off-by: tariq-hasan <mmtariquehsn@gmail.com>
I wonder if we should re-run Unit Test 1.27.1 given that this issue was flagged before in other PRs and jobs were restarted. Other jobs look to be okay. I was also wondering if a dedicated issue needs to be opened to look into this. |
@tariq-hasan I tried to re-run 5 times, but that case never succeeded in CI... |
After I restarted it 6 times, that case succeeded. That case is so flaky... |
Actually, we already have a dedicated issue: #2269 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tariq-hasan, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Following the suggestion to keep the test fields private within Go unit tests, this PR implements the necessary changes.
The unit tests for Go have been run and validated in this CI Workflow.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: