Update manifests #246
Merged
Update manifests #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
YujiOshima
force-pushed
the
kf-namespace
branch
from
c2e979a to
f48778f
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardsliu, YujiOshima The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
lkpdn
pushed a commit
to lkpdn/katib
that referenced
this pull request
Nov 26, 2018
Commit b6f8e07 ("Update manifests (kubeflow#246)") has just changed the namespace as a whole. This new manifest should be updated as well. Fixes: 67e94c7 ("Set MYSQL_ROOT_PASSWORD via Secret (kubeflow#253)") Signed-off-by: Koichiro Den <den@valinux.co.jp>
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#245
Signed-off-by: YujiOshima yuji.oshima0x3fd@gmail.com
This change is