-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bayesian optimization suggestion #251
Conversation
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
model_types = ["gp", "rf"] | ||
kernel_types = ["matern", "rbf"] | ||
|
||
for param in params: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need some input validations here for the param values like that in the original code, or are they already handled elsewhere?
also in the inner if-else conditions it might be cleaner to use if param.name in [...]
than a list of or
s (i know it's from the original code so not sure if it should change).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for a review! Updated.
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
/retest |
@xyhuang Could you take another look? |
thanks @YujiOshima! |
@xyhuang Thank you! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YujiOshima The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix #217
/cc @richardsliu @xyhuang
Signed-off-by: YujiOshima yuji.oshima0x3fd@gmail.com
This change is