Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade kubernetes dependency to 1.10.1 #256

Merged
merged 5 commits into from
Nov 28, 2018

Conversation

richardsliu
Copy link
Contributor

@richardsliu richardsliu commented Nov 21, 2018

This is to ensure that tf-operator can be imported to katib. Katib uses controller-runtime which is compatible with k8s 1.10.1. Tf-operator uses 1.10.0 (upgrading to 1.11.2 breaks a lot of things).

This change is Reviewable

@richardsliu
Copy link
Contributor Author

/assign @YujiOshima
/assign @gaocegege
/assign @johnugeorge

@johnugeorge
Copy link
Member

/lgtm

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@YujiOshima
Copy link
Contributor

Removing DeletePropagationForeground has a big side effect.
We need to be careful.
/hold

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 27, 2018
@richardsliu
Copy link
Contributor Author

/retest

@richardsliu
Copy link
Contributor Author

@YujiOshima Please take another look at this change. This is a short term solution until we figure out a better solution for managing dependencies across repos.

The flaws of this solution are:

  • Pods created by the batch jobs must be deleted manually;
  • Need to allow studyjob-controller to delete pods in the namespace (unsafe but no worse than what the metrics collector is already doing).

Let me know what you think.

@richardsliu
Copy link
Contributor Author

/retest

@YujiOshima
Copy link
Contributor

@richardsliu Thank you for your hard work!
/hold cancel

@YujiOshima
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 24160cb into kubeflow:master Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants