Enrich GUI #264
Merged
Enrich GUI #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YujiOshima
force-pushed
the
strudyjob-api
branch
from
c99f75e
to
9324cad
Compare
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
|
@YujiOshima |
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
YujiOshima
force-pushed
the
strudyjob-api
branch
from
9324cad
to
fb3a6e6
Compare
|
@richardsliu Thank you! I updated PTAL. |
|
/assign @richardsliu |
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
richardsliu
reviewed
Dec 10, 2018
cmd/ui/template/studyjobgen.html
Outdated
| <div> | ||
| <label for="selOptType">OptimizationType</label> | ||
| <select class="form-control form-control-sm" name="selOptType" ID="selOptType" v-model="OptType" style="min-width: 100px;"> | ||
| <option value="maximize">Maxmize</option> |
cmd/ui/template/studyjobgen.html
Outdated
| <div class="alert alert-dism buttonissible alert-success" v-if="created"> | ||
| <button type="button" class="close" data-dismiss="alert">×</button> | ||
| <h4 class="alert-heading">Created successfully!</h4> | ||
| <p class="mb-0">Sutudyjob {{`{{StudyName}}`}} has created successfully.</p> |
|
/retest |
|
@richardsliu Thank you for your comments. Fixed. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardsliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @richardsliu
This change is