Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hougangliu as a reviewer #310

Merged
merged 1 commit into from
Dec 22, 2018
Merged

add hougangliu as a reviewer #310

merged 1 commit into from
Dec 22, 2018

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Dec 21, 2018 •
edited by jlewi
Loading

This change is Reviewable

@hougangliu
Copy link
Member Author

/assign @YujiOshima @richardsliu @jlewi

@YujiOshima
Copy link
Contributor

👍
/lgtm

jlewi
jlewi reviewed Dec 21, 2018
View reviewed changes
OWNERS
@@ -9,3 +9,4 @@ reviewers:
- libbyandhelen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the indentation; these items should not be indented relative to jose5918.

@hougangliu
Copy link
Member Author

@jlewi It is very strange that all reviewers keep same indentation in my local repo, but in GitHub review page it looks these items are indented relative to jose5918.
When I cut down one indentation for all items. It seems that GitHub review page show rightly

@jlewi
Copy link
Contributor

jlewi commented Dec 21, 2018

Is there a mix of tabs and spaces?

@hougangliu
Copy link
Member Author

@jlewi I verified that all indentations are spaces. When I dd the first two lines and yy in the last line as change set. github page shows well now.
Maybe you can git clone and verify it if you're interested :)

@hougangliu
Copy link
Member Author

/retest

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cbe91f8 into kubeflow:master Dec 22, 2018
@hougangliu hougangliu deleted the reviewer-application branch December 23, 2018 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi jlewi left review comments

@libbyandhelen libbyandhelen Awaiting requested review from libbyandhelen

@texasmichelle texasmichelle Awaiting requested review from texasmichelle

Assignees

@jlewi jlewi

@YujiOshima YujiOshima

@richardsliu richardsliu

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hougangliu @YujiOshima @jlewi @richardsliu @k8s-ci-robot