Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xgboost example using Bayesian optimization #320

Merged
merged 2 commits into from
Jan 15, 2019

Conversation

richardsliu
Copy link
Contributor

@richardsliu richardsliu commented Jan 11, 2019

This example uses the image built from https://github.com/kubeflow/examples/tree/master/xgboost_ames_housing.

The hyperparameters being tuned are:

  • Number of boost trees
  • learning rate

We are trying to minimize the mean_absolute_error.


This change is Reviewable

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@richardsliu
Copy link
Contributor Author

/hold

@johnugeorge
Copy link
Member

Is it using default metric collector?

@richardsliu
Copy link
Contributor Author

@johnugeorge Yes, the default metric collector works here (assuming that the training worker outputs logs in the expected format).

Copy link
Member

@hougangliu hougangliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @richardsliu, @ddysher, and @texasmichelle)


examples/xgboost-bayesian-example.yaml, line 17 at r1 (raw file):

  requestcount: 10
  metricsnames:
    - mean_absolute_error

mean_absolute_error is not in need here since it is objectivevaluename


examples/xgboost-bayesian-example.yaml, line 61 at r1 (raw file):

              - name: datadir
                persistentVolumeClaim:
                claimName: claim

please add pvc yaml in this patch, too

Copy link
Member

@hougangliu hougangliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @richardsliu, @ddysher, and @texasmichelle)


examples/xgboost-bayesian-example.yaml, line 13 at r1 (raw file):

  owner: crd
  optimizationtype: minimize
  objectivevaluename: mean_absolute_error

I wonder if https://github.com/kubeflow/examples/blob/master/xgboost_ames_housing/housing.py can print mean_absolute_error in log

@richardsliu
Copy link
Contributor Author

@hougangliu The example docker image is being fixed in this PR: kubeflow/examples#476. I added comments clarifying the prerequisites.

@hougangliu
Copy link
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants