Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the example UI is generated by random-example. #333

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

gyliu513
Copy link
Member

@gyliu513 gyliu513 commented Jan 21, 2019

This change is Reviewable

README.md Outdated
@@ -83,7 +83,8 @@ Please see [MinikubeDemo.md](./examples/MinikubeDemo.md) for more details.
## Web UI

Katib provides a Web UI.
You can visualize general trend of Hyper parameter space and each training history.
You can visualize general trend of Hyper parameter space and each training history. The following example UI
is generated by [random-example](https://github.com/kubeflow/katib/blob/master/examples/random-example.yaml).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But the example UI is not generated by the example (studyjob name and requestcount don't match at least).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hougangliu Updated a bit to tell end user can use the example to generate a similar UI. ;-)

@hougangliu
Copy link
Member

/lgtm

@YujiOshima
Copy link
Contributor

Thanks!! /approve

@gyliu513
Copy link
Member Author

@YujiOshima I think the approve label need in a separate line to take effect ;-)

@YujiOshima
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c67892f into kubeflow:master Jan 24, 2019
@gyliu513 gyliu513 deleted the ui branch January 25, 2019 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants