Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omit empty fields for studyjob status #336

Merged
merged 1 commit into from
Jan 22, 2019
Merged

omit empty fields for studyjob status #336

merged 1 commit into from
Jan 22, 2019

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Jan 22, 2019

EarlyStoppingParameterID should not be shown in studyjob status to mislead user since EarlyStopping feature cannot work now.


This change is Reviewable

@hougangliu
Copy link
Member Author

/assign @YujiOshima @richardsliu

@hougangliu
Copy link
Member Author

BTW, will EarlyStopping feature be in katib plan? @YujiOshima @richardsliu @gaocegege

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8545970 into kubeflow:master Jan 22, 2019
@hougangliu hougangliu deleted the udpate-status branch January 25, 2019 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants