Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading controller runtime and k8s to 1.11.2 #376

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Upgrading controller runtime and k8s to 1.11.2 #376

merged 1 commit into from
Feb 14, 2019

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Feb 14, 2019 •
edited by jlewi
Loading

  1. This upgrades the k8s to 1.11.2 version and controller runtime to 0.1.7
  2. Removes pod control as it is not needed with DeletePropagationForeground

This change is Reviewable

@hougangliu
Copy link
Member

/lgtm

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 03ca08f into kubeflow:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jose5918 jose5918 Awaiting requested review from jose5918

@libbyandhelen libbyandhelen Awaiting requested review from libbyandhelen

Assignees

@hougangliu hougangliu

@richardsliu richardsliu

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnugeorge @hougangliu @richardsliu @k8s-ci-robot