Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add build and test for suggestion nasrl #401

Merged
merged 1 commit into from
Feb 22, 2019
Merged

add build and test for suggestion nasrl #401

merged 1 commit into from
Feb 22, 2019

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Feb 21, 2019 •
edited by jlewi
Loading

This change is Reviewable

@andreyvelich
Copy link
Member

@hougangliu Thank you for your PR! Does it fix this issue: #400 ?

@hougangliu
Copy link
Member Author

@hougangliu Thank you for your PR! Does it fix this issue: #400 ?

Yes, it can build nas-rl image, too

@hougangliu
Copy link
Member Author

Fixes: #400

@hougangliu
Copy link
Member Author

/retest

3 similar comments
@hougangliu
Copy link
Member Author

/retest

@hougangliu
Copy link
Member Author

/retest

@hougangliu
Copy link
Member Author

/retest

@hougangliu
Copy link
Member Author

hougangliu commented Feb 21, 2019 •
edited
Loading

/assign @YujiOshima @johnugeorge @richardsliu
it seems UT machine is under pressures on resource so that kubeflow-katib-presubmit always fails. I will retest when machine comes back,

@YujiOshima
Copy link
Contributor

YujiOshima commented Feb 21, 2019 •
edited
Loading

@hougangliu Thanks!
/lgtm

@hougangliu
Copy link
Member Author

/retest

4 similar comments
@hougangliu
Copy link
Member Author

/retest

@hougangliu
Copy link
Member Author

/retest

@hougangliu
Copy link
Member Author

/retest

@andreyvelich
Copy link
Member

/retest

@hougangliu
Copy link
Member Author

/lgtm
/approve

@k8s-ci-robot
Copy link

@hougangliu: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hougangliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@YujiOshima
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 46d2dc7 into kubeflow:master Feb 22, 2019
@andreyvelich andreyvelich mentioned this pull request Feb 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddysher ddysher Awaiting requested review from ddysher

@libbyandhelen libbyandhelen Awaiting requested review from libbyandhelen

Assignees

@johnugeorge johnugeorge

@YujiOshima YujiOshima

@richardsliu richardsliu

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hougangliu @andreyvelich @YujiOshima @k8s-ci-robot @johnugeorge @richardsliu