Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix py client import error #453

Merged
merged 1 commit into from
Apr 10, 2019
Merged

fix py client import error #453

merged 1 commit into from
Apr 10, 2019

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Apr 10, 2019

This change is Reviewable

@hougangliu
Copy link
Member Author

/assign @johnugeorge

@johnugeorge
Copy link
Member

@hougangliu Can you please explain why you need this change?

@hougangliu
Copy link
Member Author

@hougangliu Can you please explain why you need this change?

pipeline katib-laucher uses studyjob python client. and this patch fixes 2 import error:

  1. multiprocessing is used but not import
  2. util.JobTimeoutError is not defined.

When timeout occurs, the two issue triggers

@johnugeorge
Copy link
Member

Ok. It was not used earlier
/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 05569bc into kubeflow:master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants