Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable test for v1alpha2 #465

Merged
merged 6 commits into from
Apr 26, 2019
Merged

enable test for v1alpha2 #465

merged 6 commits into from
Apr 26, 2019

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Apr 24, 2019 •
edited
Loading

This is initial version to enable test for v1alpha2.
Now, for v1alpha2 test, only build katib-controller and test if the deployment Pod is running or not.
After other components done, add corresponding tests one by one.

@richardsliu @johnugeorge @YujiOshima @gaocegege Please help review it. thanks!

This change is Reviewable

@hougangliu
Copy link
Member Author

/hold

@hougangliu hougangliu changed the title WIP: enable test for v1alpha2 enable test for v1alpha2 Apr 24, 2019
@hougangliu
Copy link
Member Author

/hold cancle

@hougangliu
Copy link
Member Author

/hold cancel

@gaocegege
Copy link
Member

Thanks for your contribution! Let's wait for the CI result.

@kubeflow kubeflow deleted a comment from k8s-ci-robot Apr 24, 2019
@hougangliu
Copy link
Member Author

/assign @richardsliu @johnugeorge @YujiOshima @gaocegege

andreyvelich
andreyvelich reviewed Apr 24, 2019
View reviewed changes
examples/v1alpha2/random-example.yaml Outdated Show resolved Hide resolved
examples/v1alpha2/random-example.yaml Outdated Show resolved Hide resolved
examples/v1alpha2/random-example.yaml Outdated Show resolved Hide resolved
manifests/v1alpha2/katib-controller/crds.yaml Show resolved Hide resolved
johnugeorge
johnugeorge reviewed Apr 25, 2019
View reviewed changes
prow_config.yaml
component: workflows-v1alpha2
name: e2e-v1alpha2-release
job_types:
- postsubmit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need postsubmit for v1alpha2 if the same image is built ?

Copy link
Member Author

@hougangliu hougangliu Apr 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future, I wonder if all the images containing both versions (at least, metricsCollectors may be dropped). keep it as it is now, update it later if in need

@hougangliu
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member

/lgtm

@andreyvelich
Copy link
Member

Thanks, lgtm!

@hougangliu
Copy link
Member Author

Thanks for review
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hougangliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 78a4563 into kubeflow:master Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnugeorge johnugeorge johnugeorge left review comments

@andreyvelich andreyvelich andreyvelich left review comments

@richardsliu richardsliu richardsliu left review comments

@libbyandhelen libbyandhelen Awaiting requested review from libbyandhelen

@texasmichelle texasmichelle Awaiting requested review from texasmichelle

Assignees

@johnugeorge johnugeorge

@gaocegege gaocegege

@YujiOshima YujiOshima

@richardsliu richardsliu

Labels
approved lgtm size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hougangliu @gaocegege @johnugeorge @andreyvelich @k8s-ci-robot @richardsliu @YujiOshima