chore: Skip test when code is not changed #467
Conversation
Signed-off-by: Ce Gao <gaoce@caicloud.io>
|
@gaocegege: GitHub didn't allow me to request PR reviews from the following users: alexandraj777. Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thanks @gaocegege! I don't know enough about configuring prow and the structure of go projects to know if this is what we want, but it seems good. The only suggestion I'd make is to include the prow config itself...is there any way to re-run tests when the prow config file changes? |
|
/assign @jlewi |
|
Oh, I assigned @jlewi because it looks like he was the other person to touch these files, not sure if you're allowed to "lgtm" on your own PRs, so lmk if I've done something non-standard 😄 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Adding initial v1alpha2 API controller (kubeflow#457) * Adding initial v1alpha2 controller * Adding logs * Adding comments * Adding template functions for experiment * Adding error checks * chore: Skip test when code is not changed (kubeflow#467) Signed-off-by: Ce Gao <gaoce@caicloud.io> * Add serviceAccountName in UI deployment (kubeflow#469) * feat: Introduce suggestion Signed-off-by: Ce Gao <gaoce@caicloud.io> * owners: Add xinyi yu Signed-off-by: Ce Gao <gaoce@caicloud.io>
Fix #374
/cc @alexandraj777
Signed-off-by: Ce Gao gaoce@caicloud.io
This change is