Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validation and mutating webhook for experiment #473

Merged
merged 6 commits into from
Apr 27, 2019
Merged

validation and mutating webhook for experiment #473

merged 6 commits into from
Apr 27, 2019

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Apr 25, 2019 •
edited by jlewi
Loading

This change is Reviewable

@hougangliu hougangliu changed the title WIP: validation and mutating webhook for experiment validation and mutating webhook for experiment Apr 26, 2019
@hougangliu
Copy link
Member Author

/assign @johnugeorge @richardsliu @YujiOshima @gaocegege @andreyvelich

@johnugeorge
Copy link
Member

@hougangliu Can you have a look at my previous comment? Is it possible to avoid client-go dependency directly? The problem is that we will then have to keep it as a direct dependency in Godep and then have to worry about the changes in client-go library. However, if we use client of controller-runtime(iwhich indirectly uses client-go), we have to just upgrade controller-runtime whenever required

@hougangliu
Copy link
Member Author

hougangliu commented Apr 26, 2019 •
edited
Loading

@hougangliu Can you have a look at my previous comment? Is it possible to avoid client-go dependency directly? The problem is that we will then have to keep it as a direct dependency in Godep and then have to worry about the changes in client-go library. However, if we use client of controller-runtime(iwhich indirectly uses client-go), we have to just upgrade controller-runtime whenever required

OK, I can try. Thanks!
BTW, I cannot see your related comment. Not published?

@johnugeorge
Copy link
Member

Sorry. Forgot to publish

YujiOshima
YujiOshima reviewed Apr 27, 2019
View reviewed changes
pkg/controller/v1alpha2/experiment/util/webhook_util.go
k8syaml "k8s.io/apimachinery/pkg/util/yaml"
)

func ValidateExperiment(instance *ep_v1alpha2.Experiment) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add validation for Experiment name that the name is already registered in DB or not?
If users set RetainHistoricalData true, the previous data will remain even the CR was deleted.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done! thanks!

@johnugeorge
Copy link
Member

/lgtm

@hougangliu
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hougangliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6f5c5c7 into kubeflow:master Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreyvelich andreyvelich andreyvelich left review comments

@YujiOshima YujiOshima YujiOshima left review comments

@johnugeorge johnugeorge johnugeorge left review comments

@Akado2009 Akado2009 Awaiting requested review from Akado2009

@texasmichelle texasmichelle Awaiting requested review from texasmichelle

Assignees

@johnugeorge johnugeorge

@gaocegege gaocegege

@YujiOshima YujiOshima

@andreyvelich andreyvelich

@richardsliu richardsliu

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hougangliu @johnugeorge @k8s-ci-robot @YujiOshima @andreyvelich @gaocegege @richardsliu