Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ut test and enable ut-test of v1alpha2 #524

Merged
merged 1 commit into from
May 15, 2019
Merged

Fix ut test and enable ut-test of v1alpha2 #524

merged 1 commit into from
May 15, 2019

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented May 15, 2019 •
edited by jlewi
Loading

This change is Reviewable

gaocegege
gaocegege reviewed May 15, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gaocegege
gaocegege reviewed May 15, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run dep ensure to remove useless dep, or I think the ci will fail.

@hougangliu
Copy link
Member Author

hougangliu commented May 15, 2019 •
edited
Loading

Please run dep ensure to remove useless dep, or I think the ci will fail.

In test workflow, dep-ensure run it

@k8s-ci-robot k8s-ci-robot merged commit 3d1a8ca into kubeflow:master May 15, 2019
@hougangliu hougangliu deleted the fix-ut branch May 17, 2019 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@garganubhav garganubhav Awaiting requested review from garganubhav

Assignees

@gaocegege gaocegege

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hougangliu @k8s-ci-robot @gaocegege