Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove dep ensure in CI #525

Merged
merged 6 commits into from
May 15, 2019
Merged

chore: Remove dep ensure in CI #525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
078e322
chore: Move unit test before image building in v1alpha2
gaocegege May 15, 2019
4d9f50a
fix: Move python suggestions build to dep
gaocegege May 15, 2019
1c230bd
chore: Move more layers to dep
gaocegege May 15, 2019
c4c742c
chore: Add dep and remove depensure in CI
gaocegege May 15, 2019
e60501c
fix: Run setup cluster later
gaocegege May 15, 2019
ad841ef
fix: Address comments
gaocegege May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
The diff you're trying to view is too large. We only load the first 3000 changed files.
3 changes: 0 additions & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,3 @@ ehthumbs_vista.db

## Recycle Bin used on file shares
$RECYCLE.BIN/

## Vendor packages
vendor/
1 change: 0 additions & 1 deletion test/scripts/v1alpha1/create-cluster.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ gcloud auth activate-service-account --key-file=${GOOGLE_APPLICATION_CREDENTIALS
echo "Creating GPU cluster"
gcloud --project ${PROJECT} beta container clusters create ${CLUSTER_NAME} \
--zone ${ZONE} \
--accelerator type=nvidia-tesla-k80,count=1 \
--cluster-version 1.11
echo "Configuring kubectl"
gcloud --project ${PROJECT} container clusters get-credentials ${CLUSTER_NAME} \
Expand Down
38 changes: 0 additions & 38 deletions test/scripts/v1alpha1/get-vendor-packages.sh
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion test/scripts/v1alpha2/create-cluster.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ gcloud auth activate-service-account --key-file=${GOOGLE_APPLICATION_CREDENTIALS
echo "Creating GPU cluster"
gcloud --project ${PROJECT} beta container clusters create ${CLUSTER_NAME} \
--zone ${ZONE} \
--accelerator type=nvidia-tesla-k80,count=1 \
--cluster-version 1.11
echo "Configuring kubectl"
gcloud --project ${PROJECT} container clusters get-credentials ${CLUSTER_NAME} \
Expand Down
38 changes: 0 additions & 38 deletions test/scripts/v1alpha2/get-vendor-packages.sh
View file
Open in desktop

This file was deleted.

40 changes: 13 additions & 27 deletions test/workflows/components/workflows-v1alpha1.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,18 @@
template: "checkout",
}],
[
{
name: "dep-ensure",
template: "dep-ensure",
}
],
[
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove build template line also?

{
name: "python-tests",
template: "python-tests",
},
{
name: "build-suggestion-bo",
template: "build-suggestion-bo",
},
{
name: "build-suggestion-nasrl",
template: "build-suggestion-nasrl",
},
{
name: "build-manager",
template: "build-manager",
Expand All @@ -234,14 +240,6 @@
name: "build-suggestion-hyperband",
template: "build-suggestion-hyperband",
},
{
name: "build-suggestion-bo",
template: "build-suggestion-bo",
},
{
name: "build-suggestion-nasrl",
template: "build-suggestion-nasrl",
},
{
name: "build-earlystopping-median",
template: "build-earlystopping-median",
Expand All @@ -255,8 +253,7 @@
template: "create-pr-symlink",
},
],
[ // Setup cluster needs to run after build because we depend on the chart
// created by the build statement.
[
{
name: "setup-cluster",
template: "setup-cluster",
Expand All @@ -267,14 +264,6 @@
name: "unit-test",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests not changed in v1alpha1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot change it, because v1alpha1 unit test should be run after the cluster is created.

template: "unit-test",
},
],
[
{
name: "python-tests",
template: "python-tests",
},
],
[
{
name: "run-tests",
template: "run-tests",
Expand Down Expand Up @@ -344,9 +333,6 @@
"copy_artifacts",
"--bucket=" + bucket,
]), // copy-artifacts
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("dep-ensure", testWorkerImage, [
"test/scripts/v1alpha1/get-vendor-packages.sh",
]), // dep ensure
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("build-manager", testWorkerImage, [
"test/scripts/v1alpha1/build-manager.sh",
]), // build-manager
Expand Down
48 changes: 17 additions & 31 deletions test/workflows/components/workflows-v1alpha2.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,12 +204,22 @@
template: "checkout",
}],
[
{
name: "dep-ensure",
template: "dep-ensure",
}
],
[
{
name: "python-tests",
template: "python-tests",
},
{
name: "build-suggestion-bo",
template: "build-suggestion-bo",
},
{
name: "build-suggestion-nasrl",
template: "build-suggestion-nasrl",
},
{
name: "unit-test",
template: "unit-test",
},
{
name: "build-manager",
template: "build-manager",
Expand All @@ -234,14 +244,6 @@
name: "build-suggestion-hyperband",
template: "build-suggestion-hyperband",
},
{
name: "build-suggestion-bo",
template: "build-suggestion-bo",
},
{
name: "build-suggestion-nasrl",
template: "build-suggestion-nasrl",
},
{
name: "build-earlystopping-median",
template: "build-earlystopping-median",
Expand All @@ -255,25 +257,12 @@
template: "create-pr-symlink",
},
],
[ // Setup cluster needs to run after build because we depend on the chart
// created by the build statement.
[
{
name: "setup-cluster",
template: "setup-cluster",
},
],
[
{
name: "unit-test",
template: "unit-test",
},
],
[
{
name: "python-tests",
template: "python-tests",
},
],
[
{
name: "run-tests",
Expand Down Expand Up @@ -344,9 +333,6 @@
"copy_artifacts",
"--bucket=" + bucket,
]), // copy-artifacts
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("dep-ensure", testWorkerImage, [
"test/scripts/v1alpha2/get-vendor-packages.sh",
]), // dep ensure
$.parts(namespace, name, overrides).e2e(prow_env, bucket).buildTemplate("build-manager", testWorkerImage, [
"test/scripts/v1alpha2/build-manager.sh",
]), // build-manager
Expand Down
15 changes: 15 additions & 0 deletions vendor/cloud.google.com/go/AUTHORS
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading