fix: Avoid side effect

[gaocegege]

Signed-off-by: Ce Gao gaoce@caicloud.io

What this PR does / why we need it:

Fix #531

We will meet an error during the creation and retry it again and again. I strongly suggest using state compare pattern instead of current state machine based implementation. But it is another topic.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

---

This change is 

[gaocegege]

/cc @johnugeorge @richardsliu

[johnugeorge]

Thanks. This is a required change. I was about to give the comment in #496 before it got merged :)

[gaocegege]

@johnugeorge Yeah my mistake. I did not find this potential problem. And when I am running unit test in #528 I find the logic has bugs.

[gaocegege]

@johnugeorge PTAL again, thanks

[gaocegege]

/retest

[gaocegege]

@johnugeorge PTAL

[johnugeorge]

/lgtm

[johnugeorge]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [johnugeorge]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hougangliu]

/lgtm

[gaocegege]

I am not sure why why bot does not merge the PR automatically.

[johnugeorge]

Tests failed @gaocegege

[gaocegege]

So the CI will be run again after we approve one PR.

[gaocegege]

/retest