Added metric name to GetObservationLogRequest #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hougangliu
reviewed
May 20, 2019
| @@ -491,8 +492,9 @@ message ReportObservationLogReply { | |||
|
|
|||
| message GetObservationLogRequest { | |||
| string trial_name = 1; | |||
| string start_time = 2; ///The start of the time range. RFC3339 format | |||
| string end_time = 3; ///The end of the time range. RFC3339 format | |||
| string metric_name = 2; | |||
There was a problem hiding this comment.
how about s/string metric_name/repeat string metric_name_list to make it more scalable
There was a problem hiding this comment.
Can we target this enhancement in a separate PR? Currently, controller will need to pass only one metric name which would be the objective metric name.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional field 'metric_name' to GetObservationLogRequest in order to filter logs based on metric name if set
This change is