Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check if the deletion time is nil or zero #567

Merged
merged 1 commit into from
May 21, 2019

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented May 21, 2019

Signed-off-by: Ce Gao gaoce@caicloud.io

What this PR does / why we need it:

This PR is to avoid the potential bug of finalizers. The object cannot be deleted without the PR.

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:



This change is Reviewable

Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege
Copy link
Member Author

/assign @hougangliu

IsZero returns true if the value is nil or time is zero.

@johnugeorge
Copy link
Member

/lgtm

Copy link
Member Author

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 87e3a53 into kubeflow:master May 21, 2019
@gaocegege gaocegege deleted the finalizer branch May 21, 2019 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants