Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mini fix for v1alpha1 metricsCollector #600

Merged
merged 1 commit into from
May 28, 2019
Merged

Mini fix for v1alpha1 metricsCollector #600

merged 1 commit into from
May 28, 2019

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented May 28, 2019

When I configure wrong metrics-collector role for list pods in namespace kubeflow by mistake, metricsCollectors always goes to Error with message F0528 09:59:09.429051 1 main.go:81] Failed to collect logs: No Pods are found in Job v2cc12862537d2e9, which is really confusing user.


This change is Reviewable

@hougangliu
Copy link
Member Author

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 99a4359 into kubeflow:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants