Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scheme in Katib Client for v1alpha2 #620

Merged

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Jun 2, 2019

To use Experiment CRD we need to add the Scheme to the Katib Client.
Without this Scheme, we will have this error in Katib Client:

no kind is registered for the type v1alpha2.Experiment
no kind is registered for the type v1alpha2.ExperimentList

/assign @johnugeorge @richardsliu


This change is Reviewable

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d9e727d into kubeflow:master Jun 2, 2019
@andreyvelich andreyvelich deleted the v1alpha2-add-scheme-to-client branch September 27, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants