Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems in the UI for v1alpha2 #623

Merged
merged 4 commits into from
Jun 3, 2019

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Jun 3, 2019

I have tested new UI and found some problems there, this PR fixes it.

  1. Changed AlgorithmName from list to string in submit jobs by parameters.
  2. Fixed TrialPath to Trial Template in submit jobs by parameters. (Currently, in the UI we support only default configMap for Trial Template. Name of the ConfigMap is trial-template).
  3. Fixed InputSizes and OutputSizes name in submit NAS job by parameters.

If you find more problems in the UI, create issues, please.

/cc @johnugeorge @hougangliu @gaocegege @richardsliu


This change is Reviewable

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for your contribution! 🎉 👍

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c2a1995 into kubeflow:master Jun 3, 2019
@andreyvelich andreyvelich deleted the v1alpha2-fix-ui-issues branch September 27, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants