Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding extra check for Katib core namespace env #655

Closed
wants to merge 3 commits into from

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Jun 16, 2019

If DefaultKatibNamespaceEnvName is not set, it will use default namespace. This will be used in unit tests where env is not set.
/hold
Fixes: #604


This change is Reviewable

KatibNamespace
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign johnugeorge
You can assign the PR to them by writing /assign @johnugeorge in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
/lgtm

@johnugeorge
Copy link
Member Author

/hold

@johnugeorge
Copy link
Member Author

Closing this as web hooks will be disabled in unit tests after #657
/close

@k8s-ci-robot
Copy link

@johnugeorge: Closed this PR.

In response to this:

Closing this as web hooks will be disabled in unit tests after #657
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix flaky unit tests
3 participants