Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Change adding a template #656

Merged
merged 3 commits into from
Jun 19, 2019

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Jun 16, 2019

Related: #641.

I fixed issue 1 and 2 from the list.

  1. I added label to the template name.
  2. User can't accept template without name or yaml structure.

/cc @richardsliu @johnugeorge


This change is Reviewable

@andreyvelich
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member

@andreyvelich can you rebase?

@andreyvelich
Copy link
Member Author

@johnugeorge Done

@johnugeorge
Copy link
Member

/lgtm

@richardsliu
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 18, 2019
@andreyvelich
Copy link
Member Author

@richardsliu I fixed conflicts, lgtm again it, please

@johnugeorge
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 1344dc2 into kubeflow:master Jun 19, 2019
@andreyvelich andreyvelich deleted the issue-641-ui-add-template branch September 27, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants