-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable prometheus metrics for katib-controller #717
Conversation
Don't we need katib specific metrics to be exposed? |
This PR only exposes controller-runtime default metrics for controller. I will submit other PRs for experiments/trials etc. |
/test kubeflow-katib-presubmit |
1 similar comment
/test kubeflow-katib-presubmit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest
/lgtm |
/approve |
/retest |
1 similar comment
/retest |
/test kubeflow-katib-presubmit |
/retest |
/test kubeflow-katib-presubmit |
/retest |
/test kubeflow-katib-presubmit |
2 similar comments
/test kubeflow-katib-presubmit |
/test kubeflow-katib-presubmit |
Disable UI build so that the build error will not block katib CI. |
/test kubeflow-katib-presubmit |
/retest |
2 similar comments
/retest |
/retest |
/retest |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Upgrade controller-runtime to 0.1.9 and enable prometheus metrics for katib-controller
This change is