feat(apis): Add suggestion CRD API #740
Conversation
|
/assign @johnugeorge @hougangliu |
gaocegege
force-pushed
the
suggestion-crd
branch
2 times, most recently
from
81167e4 to
517e844
Compare
| // SuggestionSpec defines the desired state of Suggestion | ||
| type SuggestionSpec struct { | ||
| // Number of suggestions requested | ||
| Suggestions *int32 `json:"suggestions,omitempty"` |
There was a problem hiding this comment.
If it is not set, it will be nil
There was a problem hiding this comment.
Which situation can it get nil? I feel that Suggestion CR will always have non zero value. Do you see any other scenario?
There was a problem hiding this comment.
I think it is for #726 (comment).
The defaulting webhook can set the field to 0 if it is nil.
|
/test kubeflow-katib-presubmit |
|
Lets rebase with #741 if it goes through. |
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
gaocegege
force-pushed
the
suggestion-crd
branch
from
517e844 to
2ebf998
Compare
|
Rebased |
|
I think, PR is ready to be merged. Merge it ? |
|
/lgtm |
|
/test kubeflow-katib-presubmit Thanks |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
ubuntu repos seem to be unusually slow now |
|
/retest |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Ref #507
Special notes for your reviewer:
Release note:
This change is